Archive for the ‘WTH’ Category

[WTH] critical flaw in our review process

leave a comment

Image Credit


Let me tell you a story

Recently, I have been assigned as a reviewer for a patch provided by our partner and this is okay to me because as a peer of Settings app, it’s part of my duty to review these patches. But … sadly, there are so many problems in that patch and I thought “Ok, it’s fine, because we all would make mistakes at first especially if you are not familiar with the part of codes”, so I tried my best to comment down all problematic codes with references (like to MDN or some related codes) to make sure they  can get familiar with them more quickly and easily.

After several rounds of this process, we finally made it and I thought this patch was good enough to be landed, so I gave them r+ on this patch.

If the story ended here, then I don’t have to write any bits of words like this article. As you may know, this is not the end.

What happened next

After signing-off this patch, there are still some other reviewing processes undergoing for different part of codes. For me, I have done my works, so I just left them alone and kept focusing on new features. Someday in the morning, I randomly checked the messages on Github and noticed there was one comment about the r+ patch, just out of curiosity, I decided to click it and checked it out.

That was a comment about missing change on the entry point and this definitely broke Settings app (You can’t even do anything). But … I was sure that this did work when I gave r+ because I did try the entry point to jump to that specific app when reviewing. So what’s going on right now !?

After a while, I finally realized that they just changed the code without any further notification and because the code change is kinda huge, no one would realize this problem when reviewing patch. So what does this mean ? If you really want to set someone up in this review process, you just have to get his/her r+ on your patch and use some magical git commands to break it and NO ONE WOULD NOTICE THIS AND WOULD BLAME ON THE REVIEWER !! (I wasn’t blamed yet, but if this patch got merged and I didn’t notice this, I would be the one)


We all know this is the critical flaw in our review process, but in order to trust anyone, we haven’t forced people to tell us if the patch got changed after r+. By doing so, this would make the review process more easy and we don’t have to get stuck in some kinds of principles. Sadly, this happened to me few days ago.

Not sure what to fix here because if you are familiar with git, you can do whatever you want on commits. It is a double-edged sword which provides you so many advantages and also some shortages. I just hope this was not made on purpose …


Written by EragonJ

October 27th, 2014 at 6:05 pm

Posted in WTH

Tagged with , ,

[WTH] I hate Influenza


Image Credit


上上個星期五的中午,和同事吃完午餐回到公司後,就開始瘋狂覺得莫名的冷,就算連切換到 Mozilla Space 還是覺得很冷,我原本一直以為是空調的問題,但是直到我一直發抖到有點無法控制之後才覺得有點不太對,只能立馬請假去看醫生,而在離開前同事很強的不知道去哪邊弄到一台體溫槍,不量還好,一量就 38.6 度 … 只能趕快去找計程車回家了。

一開始還很慘的跑到一間已經關門的診所,當時真的不知道我是如何在大太陽下走到遠端的另一間診所,然後還等了快 20 分鐘看醫生,明明就沒什麼人而且看起來也沒什麼問題也是在這邊排隊,我當時整個就是靠在牆上呈現一個快死亡的狀態。

好不容易輪到我了,快速給醫生診斷之後就量了一下體溫,此時已經來到 40 度了,當時心想人生的尾端大概也不過如此吧。在拿了醫生的爛藥之後(後面有去給別的醫生看,只是退燒藥而已),趕快衝回家昏迷,就這樣整整睡了一晚,還好室友回來還有順路帶個水及簡單的食物,雖然沒什麼食慾但至少還有一種活著的感覺。






Written by EragonJ

July 14th, 2014 at 11:31 pm

Posted in WTH

Tagged with , , ,

[WTH] The blog is back

leave a comment

Image Credit


最近因為 Server 有點問題所以造成 Blog 的 Routing 出了點問題,也是因為這樣才會使得 feedburner 抓不到資料。



而我,也有幸在台灣某大資安 T 公司工作,為這個世界付出一些貢獻。

加油 😛

Written by EragonJ

October 1st, 2012 at 9:26 pm

Posted in WTH

Tagged with ,